Skip to content

Fix Project.engagements() with input.filter.project usage #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Fix Project.engagements() with input.filter.project usage #3496

merged 1 commit into from
Jun 13, 2025

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Jun 12, 2025 •
edited
Loading

New ECMA class fields have all properties defined as undefined. Keys are not optional.

So

{
  id: project.id,
  ...{ id: undefined },
}

So undefined overrides our id instead of us forcing it.

This caused queries like

query {
  project(id: "") {
    engagements(input: { filter: { project: {} } }) {
      total
      items {
        id
      }
    }
  }
}

to return more engagements than the one for the project

@CarsonF
Fix Project.engagements() with input.filter.project usage
3933fd2 
New ECMA class fields have all properties defined as undefined.
Keys are not optional.

So
```ts
{
  id: project.id,
  ...{ id: undefined },
}
```
So undefined overrides our id instead of us forcing it.
@CarsonF CarsonF added the ⏮️ Regression Reintroduction of previously fixed issues label Jun 12, 2025
@CarsonF CarsonF merged commit 90b551e into develop Jun 13, 2025
20 of 34 checks passed
@CarsonF CarsonF deleted the bugfix/engagement-list-filters branch June 13, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
⏮️ Regression Reintroduction of previously fixed issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CarsonF